[Konsole-devel] Review Request: Use web shortcuts to search selected text on the web

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104493/
-----------------------------------------------------------

(Updated April 14, 2012, 4:49 a.m.)


Review request for Konsole.


Changes
-------

* ensure the submenu of search services are always up to date
* organize the patch in a slightly better shape


Description
-------

Web shortcuts refers to the service defined in "kcmshell4 ebrowsing". That is at least used in Konqueror, Okular and Konversation.

The use case for Konsole is users (At least I...) often need to search the Internet for something they encounter when using the terminal. A unknown word, a mysterious warning message , a compilation failure message, etc. 

The code is basically stolen from Okular and Konversation. 

After applying this patch ,there will be a compilation warning related with "ProviderInfoList". I don't know why it appears but I find that as long as <KUriFilterData> is included, the warning is always there. I guess that warning message is not our's problem.

PS: there is the prior art.
http://blog.ubuntu-tweak.com/2010/11/16/gnome-terminal-with-google-search-support.html


Diffs (updated)
-----

  desktop/partui.rc bc5c15a 
  desktop/sessionui.rc 2a05e4e 
  src/SessionController.h 160c95f 
  src/SessionController.cpp f4cfb71 
  src/ViewManager.cpp c15a093 

Diff: http://git.reviewboard.kde.org/r/104493/diff/


Testing
-------


Screenshots
-----------

search through web shortcuts
  http://git.reviewboard.kde.org/r/104493/s/506/


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120414/1aa4e49c/attachment.html>