<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104493/">http://git.reviewboard.kde.org/r/104493/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated April 14, 2012, 4:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* ensure the submenu of search services are always up to date
* organize the patch in a slightly better shape</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Web shortcuts refers to the service defined in "kcmshell4 ebrowsing". That is at least used in Konqueror, Okular and Konversation.
The use case for Konsole is users (At least I...) often need to search the Internet for something they encounter when using the terminal. A unknown word, a mysterious warning message , a compilation failure message, etc.
The code is basically stolen from Okular and Konversation.
After applying this patch ,there will be a compilation warning related with "ProviderInfoList". I don't know why it appears but I find that as long as <KUriFilterData> is included, the warning is always there. I guess that warning message is not our's problem.
PS: there is the prior art.
http://blog.ubuntu-tweak.com/2010/11/16/gnome-terminal-with-google-search-support.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktop/partui.rc <span style="color: grey">(bc5c15a)</span></li>
<li>desktop/sessionui.rc <span style="color: grey">(2a05e4e)</span></li>
<li>src/SessionController.h <span style="color: grey">(160c95f)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(f4cfb71)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(c15a093)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104493/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104493/s/506/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/05/search-through-webshortcuts_400x100.png" style="border: 1px black solid;" alt="search through web shortcuts" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>