[Konsole-devel] Review Request: Add warning for unlimited scrollback

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104452/
-----------------------------------------------------------

(Updated April 1, 2012, 2:49 p.m.)


Review request for Konsole.


Changes
-------

Thanks, had forgotten about that widget.  The HistorySizeDialog will need fixing as I don't like how hiding the warning causes all the other text to move down.

Any comment on the actual warning text?


Description
-------

Some people may not realize that when using 'unlimited scrollback' the scrollback is on the hard drive unencrypted.  The recent libvte 'security' report brought this issue up.

The warning is pretty bare-bone now.  I wasn't sure if it should have more style to make it stand out more.


Diffs (updated)
-----

  src/HistorySizeWidget.cpp fcb131c 
  src/HistorySizeWidget.ui abba938 

Diff: http://git.reviewboard.kde.org/r/104452/diff/


Testing
-------


Thanks,

Kurt Hindenburg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120401/56ae3c1a/attachment.html>