[Konsole-devel] Review Request: Add warning for unlimited scrollback

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104452/#review12090
-----------------------------------------------------------


I think it would be better to use KMessageWidget to display the warning message, just like in other places in the EditProfileDialog. And displaying that warning message all the time is not that good. It would be better to show that warning message only when unlimited history is selected or in use.



- Jekyll Wu


On March 31, 2012, 10:22 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104452/
> -----------------------------------------------------------
> 
> (Updated March 31, 2012, 10:22 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Some people may not realize that when using 'unlimited scrollback' the scrollback is on the hard drive unencrypted.  The recent libvte 'security' report brought this issue up.
> 
> The warning is pretty bare-bone now.  I wasn't sure if it should have more style to make it stand out more.
> 
> 
> Diffs
> -----
> 
>   src/HistorySizeWidget.ui abba938 
> 
> Diff: http://git.reviewboard.kde.org/r/104452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120401/596b98db/attachment.html>