[Konsole-devel] Review Request: Do not display "Default Profile" and the first "default" user profile in "New Tab" profiles list

[Francesco Cecconi]

> On Sept. 20, 2011, 2:19 p.m., Kurt Hindenburg wrote:
> > Thanks.  The one concern I have is where the user has a non-default profile in the list.  Pressing the tab/window shortcut will start a default profile (not listed in menu).  Do you think this will confuse users that pressing the shortcut won't open the profile listed in menu?
> > 
> > What issues where you having with the '&'?

I believe that the user that uses the tab/window shortcut, expects himself starting a default profile and making a different choice in the profile menu.

> What issues where you having with the '&'?

After some show/unshow action in "Manage Profile" I have this situation

defaultProfile()->name --> "Shell"
action->name           --> "&Shell"

and the "if" compare it fails.
Well, the same issue is valid for the "if" of the previous foreach but I can create a new patch for that or I can update this one.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102670/#review6681
-----------------------------------------------------------


On Sept. 20, 2011, 12:15 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102670/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2011, 12:15 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Do not display "Default Profile" and the first user profile if it is checked as the "default"
> 
> 
> This addresses bug 245478.
>     http://bugs.kde.org/show_bug.cgi?id=245478
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 507fbe3 
> 
> Diff: http://git.reviewboard.kde.org/r/102670/diff
> 
> 
> Testing
> -------
> 
> resolve issue reported by Kurt on https://bugs.kde.org/show_bug.cgi?id=245478 - #11
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110921/4663d054/attachment.html>