[Konsole-devel] Review Request: Do not display "Default Profile" and the first "default" user profile in "New Tab" profiles list

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102670/#review6681
-----------------------------------------------------------


Thanks.  The one concern I have is where the user has a non-default profile in the list.  Pressing the tab/window shortcut will start a default profile (not listed in menu).  Do you think this will confuse users that pressing the shortcut won't open the profile listed in menu?

What issues where you having with the '&'?

- Kurt


On Sept. 20, 2011, 12:15 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102670/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2011, 12:15 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Do not display "Default Profile" and the first user profile if it is checked as the "default"
> 
> 
> This addresses bug 245478.
>     http://bugs.kde.org/show_bug.cgi?id=245478
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 507fbe3 
> 
> Diff: http://git.reviewboard.kde.org/r/102670/diff
> 
> 
> Testing
> -------
> 
> resolve issue reported by Kurt on https://bugs.kde.org/show_bug.cgi?id=245478 - #11
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110920/4c2a6ab3/attachment.html>