[Konsole-devel] Review Request: Do not (sometimes) delete the bottom line of screen after resizing

[Gu Rui]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102177/#review6291
-----------------------------------------------------------


I think the +1 is to cope with conditions when new_lines = 0. But I don't think the copy for loop is right. For example, you can resize a konsole windows as minimal as possible so that there is no shell stuff on the screen, only menubar and tab bar. Then maximize the window. You would get an empty window but the first line.

- Gu


On Aug. 2, 2011, 6:51 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102177/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2011, 6:51 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This patch eliminate the problem described in comment #1 of bug #192221. However,  I am not sure that patch is really correct and would not cause new problems, because I do not quite understand why the Screen class always allocate spaces for N+1 lines when it is set to has N lines.
> 
> 
> This addresses bug 192221.
>     http://bugs.kde.org/show_bug.cgi?id=192221
> 
> 
> Diffs
> -----
> 
>   src/Screen.cpp ecd1642 
> 
> Diff: http://git.reviewboard.kde.org/r/102177/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110906/28032ae1/attachment.html>