[Konsole-devel] Review Request: Draw unable-to-simulate line characters in the normal way, i.e., using the glyph provided by font

[Jekyll Wu]

> On Oct. 16, 2011, 4:13 a.m., Kurt Hindenburg wrote:
> > It does seem to print those characters.  However, when I 'cat tests/9x15.repertoire-utf8' it crashes konsole.
> > I'll test more later - if you could see if you can reproduce the crash.

In my observation, 'cat tests/9x15.repertoire-utf8' does not crash konsole immediately, but only occassionally when I press 'Enter' then 'Ctrl+D' quickly and successively.

However, that crash also happens on master. Konsole-2.7.2 is OK.  With the help of 'git bisect', I think that problem was introduced by commit c335324f31e946d4e3a0c63d1fbed8c114aea987 which fixes bug #96536.


- Jekyll


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102836/#review7364
-----------------------------------------------------------


On Oct. 12, 2011, 2:05 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102836/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2011, 2:05 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Currently konsole draw most line characters itself, instead of using the glyph provided by font. Unfortunately, the model of 5x5 pixel matrix can't be used to simulate and draw a few of them. So the result is those chracters are not drawn, leaving whitespace in its place.
> 
> The patch simply reduce the range of line charaters to the actually supported set. So those unsupported line characters are drawn in the normal way of using the glyph provided by font. 
> 
> This is more like workaround than solution, but I think it is bettern than current situation.
> 
> 
> This addresses bug 210329.
>     http://bugs.kde.org/show_bug.cgi?id=210329
> 
> 
> Diffs
> -----
> 
>   src/Character.h 9fde2ee 
>   src/TerminalDisplay.cpp b416f41 
> 
> Diff: http://git.reviewboard.kde.org/r/102836/diff/diff
> 
> 
> Testing
> -------
> 
> Use comment #4 of bug #210329 as a simple test. Seems fine, no regression observed so far.
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20111016/b4c33e31/attachment.html>