<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102836/">http://git.reviewboard.kde.org/r/102836/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 16th, 2011, 4:13 a.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It does seem to print those characters. However, when I 'cat tests/9x15.repertoire-utf8' it crashes konsole.
I'll test more later - if you could see if you can reproduce the crash.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In my observation, 'cat tests/9x15.repertoire-utf8' does not crash konsole immediately, but only occassionally when I press 'Enter' then 'Ctrl+D' quickly and successively.
However, that crash also happens on master. Konsole-2.7.2 is OK. With the help of 'git bisect', I think that problem was introduced by commit c335324f31e946d4e3a0c63d1fbed8c114aea987 which fixes bug #96536.
</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On October 12th, 2011, 2:05 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2011, 2:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently konsole draw most line characters itself, instead of using the glyph provided by font. Unfortunately, the model of 5x5 pixel matrix can't be used to simulate and draw a few of them. So the result is those chracters are not drawn, leaving whitespace in its place.
The patch simply reduce the range of line charaters to the actually supported set. So those unsupported line characters are drawn in the normal way of using the glyph provided by font.
This is more like workaround than solution, but I think it is bettern than current situation.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use comment #4 of bug #210329 as a simple test. Seems fine, no regression observed so far.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=210329">210329</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Character.h <span style="color: grey">(9fde2ee)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(b416f41)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102836/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>