[Konsole-devel] Review Request: allow passing Shift+Tab to terminal process when split view is in use

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102834/#review7363
-----------------------------------------------------------


This review has been submitted with commit 105043b75c6d6906073bff2f5c6a522c0ad1a446 by Jekyll Wu to branch master.

- Commit Hook


On Oct. 12, 2011, 5:51 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102834/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2011, 5:51 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> The real problem is konsole only disables the implicit focus switching through 'Tab', but still allows implicit focus switching through 'Ctrl+Tab'. So even when the shortcut of 'Next View Container' is set as 'None', Shift+Tab will cause implicit focus switching.
> 
> The easiest fix is simply disable implicit focus switching through 'Shift+tab', too. But that may cause trouble for host apps of konsole kpart. For example, when using the terminal-panel in dolphin, 'Shift+tab' is the only way(AFAIK) to move the focus away from the terminal-panel using keyboard only.  So it seems sensible to allow 'Shift+Tab' in the kpart.
> 
> The attached patch is basically an experimental hack. It disables 'Shift+Tab' by reimplementing the focusNextPrevChild(bool) method in class MainWindow(which is used only by stand-alone konsole). Another possible way is adding another flag _allowImplicitFocusSwitching into class ViewSplitter, and set it as true in kpart, or false in stand-alone konsole.
> 
> 
> This addresses bug 244514.
>     http://bugs.kde.org/show_bug.cgi?id=244514
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h 26d9139 
>   src/MainWindow.cpp 32491a8 
>   src/TerminalDisplay.h f9a0508 
>   src/TerminalDisplay.cpp b416f41 
> 
> Diff: http://git.reviewboard.kde.org/r/102834/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20111016/b08983b6/attachment.html>