<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102834/">http://git.reviewboard.kde.org/r/102834/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 105043b75c6d6906073bff2f5c6a522c0ad1a446 by Jekyll Wu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 12th, 2011, 5:51 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2011, 5:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The real problem is konsole only disables the implicit focus switching through 'Tab', but still allows implicit focus switching through 'Ctrl+Tab'. So even when the shortcut of 'Next View Container' is set as 'None', Shift+Tab will cause implicit focus switching.
The easiest fix is simply disable implicit focus switching through 'Shift+tab', too. But that may cause trouble for host apps of konsole kpart. For example, when using the terminal-panel in dolphin, 'Shift+tab' is the only way(AFAIK) to move the focus away from the terminal-panel using keyboard only. So it seems sensible to allow 'Shift+Tab' in the kpart.
The attached patch is basically an experimental hack. It disables 'Shift+Tab' by reimplementing the focusNextPrevChild(bool) method in class MainWindow(which is used only by stand-alone konsole). Another possible way is adding another flag _allowImplicitFocusSwitching into class ViewSplitter, and set it as true in kpart, or false in stand-alone konsole.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=244514">244514</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.h <span style="color: grey">(26d9139)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(32491a8)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(f9a0508)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(b416f41)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102834/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>