[Konsole-devel] Review Request: Make a 'Configure Konsole' to put all the app wide, non profile-specific, options

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100845/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

There are a few app wide, non profile-specific, options that should be in the main configure dialog.  This patch only does 1 as a sample and first attempt at this type of dialog.

One thing that needs cleared up is why   settings.cpp and settings/generalsettings.cpp need to be in the konsole__KDEINIT.cpp in CMakeList.txt.  

Comments welcomed.


Diffs
-----

  src/settings/konsole.kcfg PRE-CREATION 
  src/settings/settings.kcfgc PRE-CREATION 
  src/settings/generalsettings.ui PRE-CREATION 
  src/settings/generalsettings.cpp PRE-CREATION 
  src/ViewManager.h bf17b4d 
  src/ViewManager.cpp 56fbec6 
  src/settings/generalsettings.h PRE-CREATION 
  src/Profile.h 8aa6dfc 
  src/Profile.cpp 47e45fc 
  src/MainWindow.h 2e4276d 
  src/MainWindow.cpp 046c09a 
  src/EditProfileDialog.ui 0072f82 
  src/EditProfileDialog.h e37c77e 
  src/EditProfileDialog.cpp 073ccc4 
  desktop/konsoleui.rc 32e222b 
  src/CMakeLists.txt e17b277 

Diff: http://git.reviewboard.kde.org/r/100845/diff


Testing
-------

The one options appears to work OK AFAIK.


Thanks,

Kurt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110312/2b774bec/attachment.html>