<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100845/">http://git.reviewboard.kde.org/r/100845/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are a few app wide, non profile-specific, options that should be in the main configure dialog. This patch only does 1 as a sample and first attempt at this type of dialog.
One thing that needs cleared up is why settings.cpp and settings/generalsettings.cpp need to be in the konsole__KDEINIT.cpp in CMakeList.txt.
Comments welcomed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The one options appears to work OK AFAIK.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/settings/konsole.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/settings/settings.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/settings/generalsettings.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/settings/generalsettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ViewManager.h <span style="color: grey">(bf17b4d)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(56fbec6)</span></li>
<li>src/settings/generalsettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/Profile.h <span style="color: grey">(8aa6dfc)</span></li>
<li>src/Profile.cpp <span style="color: grey">(47e45fc)</span></li>
<li>src/MainWindow.h <span style="color: grey">(2e4276d)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(046c09a)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(0072f82)</span></li>
<li>src/EditProfileDialog.h <span style="color: grey">(e37c77e)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(073ccc4)</span></li>
<li>desktop/konsoleui.rc <span style="color: grey">(32e222b)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(e17b277)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100845/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>