[Konsole-devel] Review Request: add shortcuts to jump to top & bottom of history

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102124/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

The shortcut of jumping to top of history is for the request of #45950

The shortcut of jumping to bottom of history is added not only for consistency, but also to be used for #38390, especially its comment #9 and #10. 

Possible improvement:

1). add the two new entries into all .keytab files

2). it feel strange that Vt102Emualtion.cpp includes TerminalDisplay.h in order to call its scrolling function. The dependency looks reversed. Maybe it is better that Vt102Emualtion just emit signal containing necessary argument, which (finally) triggers the code in TerminalDisplay to do the scroll operation.


This addresses bugs 38390 and 45950.
    http://bugs.kde.org/show_bug.cgi?id=38390
    http://bugs.kde.org/show_bug.cgi?id=45950


Diffs
-----

  data/keyboard-layouts/default.keytab aebd8cf 
  src/KeyboardTranslator.h da5ed6c 
  src/KeyboardTranslator.cpp 5fc95d6 
  src/Vt102Emulation.cpp c0c2a8b 

Diff: http://git.reviewboard.kde.org/r/102124/diff


Testing
-------


Thanks,

Jekyll

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110729/b6f1d6af/attachment.html>