<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102124/">http://git.reviewboard.kde.org/r/102124/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The shortcut of jumping to top of history is for the request of #45950
The shortcut of jumping to bottom of history is added not only for consistency, but also to be used for #38390, especially its comment #9 and #10.
Possible improvement:
1). add the two new entries into all .keytab files
2). it feel strange that Vt102Emualtion.cpp includes TerminalDisplay.h in order to call its scrolling function. The dependency looks reversed. Maybe it is better that Vt102Emualtion just emit signal containing necessary argument, which (finally) triggers the code in TerminalDisplay to do the scroll operation.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=38390">38390</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=45950">45950</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/keyboard-layouts/default.keytab <span style="color: grey">(aebd8cf)</span></li>
<li>src/KeyboardTranslator.h <span style="color: grey">(da5ed6c)</span></li>
<li>src/KeyboardTranslator.cpp <span style="color: grey">(5fc95d6)</span></li>
<li>src/Vt102Emulation.cpp <span style="color: grey">(c0c2a8b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102124/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>