[Konsole-devel] Re: Review Request: Do not join multiple lines seamlessly. Instead, use SPACE as delimiter when joining them

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102060/#review5065
-----------------------------------------------------------

Ship it!


http://commits.kde.org/konsole/4f8da80fec79b8d229bfb75d5825b65a3f4bea61

- Kurt


On July 23, 2011, 6:09 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102060/
> -----------------------------------------------------------
> 
> (Updated July 23, 2011, 6:09 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Currently, when users use ctrl+mouse to select and copy multiple lines , those lines are joined into single line in a seamless way(LINEBREAK is simply removed, thus the first character of second line will be positioned right after the last character of the first line ).
> 
> One example of copying the output of apt-get:
> 
> libmyth mythbrowser mythcontrols mythdvd mythflix mythgallery mythgame 
> mythmusic mythnews mythphone mythplugins mythtv mythtv-backend 
> 
> That two lines will be joined into one line:
> libmyth mythbrowser mythcontrols mythdvd mythflix mythgallery mythgamemythmusic mythnews mythphone mythplugins mythtv mythtv-backend 
> 
> That result is not of much use to users because that line will cause error when used in another apt-get command.  More often than not, they want to join multiple lines by substituting LINEBREAK with SPACE, as 'J' does in VIM. In this case, they want this line:
> libmyth mythbrowser mythcontrols mythdvd mythflix mythgallery mythgame mythmusic mythnews mythphone mythplugins mythtv mythtv-backend 
> 
> 
> This addresses bug 136730.
>     http://bugs.kde.org/show_bug.cgi?id=136730
> 
> 
> Diffs
> -----
> 
>   src/Screen.cpp cedad2d 
> 
> Diff: http://git.reviewboard.kde.org/r/102060/diff
> 
> 
> Testing
> -------
> 
> Have not noticed bad result.
> 
> 
> Thanks,
> 
> Jekyll
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110724/0b1c587d/attachment.html>