[Konsole-devel] Review Request: Make sure pty device has right size info when terminal process queries it

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102061/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

Whenever TeminalDisplay is resized, konsole will told the underlying pty device its new size by calling Pty::setWindowSize(). However, current code can't guarantee when the terminal process starts and queries the pty device about its size , the pty device already has the right info. This has caused some long known bugs, such as #176902.

This patch tries to guarantee that important assumption. It currently uses a hard-coded small delay, which works pretty well in practice although not that elegant. 


This addresses bugs 173999, 176902, 203185, and 229058.
    http://bugs.kde.org/show_bug.cgi?id=173999
    http://bugs.kde.org/show_bug.cgi?id=176902
    http://bugs.kde.org/show_bug.cgi?id=203185
    http://bugs.kde.org/show_bug.cgi?id=229058


Diffs
-----

  src/Session.cpp 92f06e9 
  src/Emulation.cpp e769833 
  src/Application.cpp 3d4416f 
  src/Emulation.h 2a6c371 

Diff: http://git.reviewboard.kde.org/r/102061/diff


Testing
-------

>From my experience, those bugs mentioned above are fixed by this patch. I have not noticed any issue caused by this patch


Thanks,

Jekyll

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110723/538dd5e3/attachment.html>