[Konsole-devel] Review Request: Split ViewManager::applyProfile() into two methods.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102321/#review5699
-----------------------------------------------------------


This review has been submitted with commit e8fa5317091055b821ab972411753b8d4c729929 by Jekyll Wu to branch master.

- Commit


On Aug. 14, 2011, 11:05 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102321/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2011, 11:05 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
>   
> The original method is splitted into applyProfileToView() which applies view-specific settings to TerminalDisplay, and applyProfileToContainer() which applies container-specific settings to ViewContainer.
> 
> This comes as preparation for fixing bug #207213.
> 
> 
> Diffs
> -----
> 
>   src/ViewManager.h cd688a5 
>   src/ViewManager.cpp 66041a3 
> 
> Diff: http://git.reviewboard.kde.org/r/102321/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110815/d26f24d6/attachment.html>