[Konsole-devel] Review Request: Split ViewManager::applyProfile() into two methods.

Jekyll Wu adaptee at gmail.com
Sun Aug 14 11:05:50 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102321/
-----------------------------------------------------------

(Updated Aug. 14, 2011, 11:05 a.m.)


Review request for Konsole.


Changes
-------

fix typo in summary


Summary (updated)
-------

  
The original method is splitted into applyProfileToView() which applies view-specific settings to TerminalDisplay, and applyProfileToContainer() which applies container-specific settings to ViewContainer.

This comes as preparation for fixing bug #207213.


Diffs
-----

  src/ViewManager.h cd688a5 
  src/ViewManager.cpp 66041a3 

Diff: http://git.reviewboard.kde.org/r/102321/diff


Testing
-------


Thanks,

Jekyll

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110814/771179c7/attachment.html>


More information about the konsole-devel mailing list