[Konsole-devel] Review Request: Move 'Show Menu Bar' and 'Fullscreen Mode' Konsole actions

[Sascha Peilicke]

> On 2010-03-04 15:02:10, Kurt Hindenburg wrote:
> > We might as well look at them all.  A lot of the menus don't make much sense.
> > Edit->Zmodem Upload
> > View->Monitor for *
> > File->Profiles
> > File->File Manager
> > 
> > Perhaps change File to Sessions (or Profiles?)
> > 
> > I notice Konq has a Window menu where a lot of items could be put.
> 
> Robert Knight wrote:
>     > Perhaps change File to Sessions (or Profiles?)
>     
>     The choice to use 'File' instead of Sessions even though it is less accurate was actually deliberate.  The reason being consistency with other applications, almost all of which have a 'File' menu that contains certain standard actions, such as actions to create new tabs, new windows and quit the application.
> 
> Robert Knight wrote:
>     > I notice Konq has a Window menu where a lot of items could be put.
>     
>     I also want to keep the number of top-level menus to a minimum.  I really don't think there is room for any more at the moment.
> 
> Sascha Peilicke wrote:
>     I agree here, less top-level windows is more.

So no further comments on any part of the patch?


- Sascha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3110/#review4368
-----------------------------------------------------------


On 2010-03-04 16:56:13, Sascha Peilicke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3110/
> -----------------------------------------------------------
> 
> (Updated 2010-03-04 16:56:13)
> 
> 
> Review request for Konsole, Robert Knight and Kurt Hindenburg.
> 
> 
> Summary
> -------
> 
> I expanded the patch quite a bit to address several issues with the menu bar:
> 
> Replaced KActions with KStandardActions wherever possible for better integration and less reinvented wheels.
> 
> Move the actions 'Show Menu Bar' and 'Fullscreen Mode' from the 'View' menu to the 'Settings' menu. Those actions are to be found in the settings menu in most other KDE apps.
> 
> The favorite profiles in the 'File' menu are now sorted under a submenu 'New Tab' together with a new default action 'Default Profile'. The "Close Tab" button moved up to the logical group.
> 
> 'Save Output' from the 'Scrollback' menu moved to the file menu, which is for loading/saving after all. The 'Search Output', find next and find previous actions where moved to the 'Edit' menu and use KStandardActions. This way it behaves more like in Okular, Dolphin, Konqi...
> 
> Scrollback options moved to 'Settings' menu and  thus the 'Scrollback' menu was removed.
> 
> 'Increase/Decrease Font Size' where renamed to 'Enlarge/Shrink Font', like we have in Okular and Konqueror.
> 
> 'Edit current profile' in the settings menu went away, this is already available via 'Configure Profiles...'.
> 
> 'Change Profile' in the settings menu went away, this is already available in the session context menu and not really settings.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/desktop/konsoleui.rc 1098894 
>   trunk/KDE/kdebase/apps/konsole/desktop/partui.rc 1098894 
>   trunk/KDE/kdebase/apps/konsole/desktop/sessionui.rc 1098894 
>   trunk/KDE/kdebase/apps/konsole/src/MainWindow.h 1098894 
>   trunk/KDE/kdebase/apps/konsole/src/MainWindow.cpp 1098894 
>   trunk/KDE/kdebase/apps/konsole/src/Part.cpp 1098894 
>   trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1098894 
> 
> Diff: http://reviewboard.kde.org/r/3110/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/3110/s/325/
> 
>   http://reviewboard.kde.org/r/3110/s/327/
> 
> 
> Thanks,
> 
> Sascha
> 
>