[Konsole-devel] Review Request: Move 'Show Menu Bar' and 'Fullscreen Mode' Konsole actions

[Sascha Peilicke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3110/
-----------------------------------------------------------

(Updated 2010-03-04 16:56:13.988087)


Review request for Konsole, Robert Knight and Kurt Hindenburg.


Summary (updated)
-------

I expanded the patch quite a bit to address several issues with the menu bar:

Replaced KActions with KStandardActions wherever possible for better integration and less reinvented wheels.

Move the actions 'Show Menu Bar' and 'Fullscreen Mode' from the 'View' menu to the 'Settings' menu. Those actions are to be found in the settings menu in most other KDE apps.

The favorite profiles in the 'File' menu are now sorted under a submenu 'New Tab' together with a new default action 'Default Profile'. The "Close Tab" button moved up to the logical group.

'Save Output' from the 'Scrollback' menu moved to the file menu, which is for loading/saving after all. The 'Search Output', find next and find previous actions where moved to the 'Edit' menu and use KStandardActions. This way it behaves more like in Okular, Dolphin, Konqi...

Scrollback options moved to 'Settings' menu and  thus the 'Scrollback' menu was removed.

'Increase/Decrease Font Size' where renamed to 'Enlarge/Shrink Font', like we have in Okular and Konqueror.

'Edit current profile' in the settings menu went away, this is already available via 'Configure Profiles...'.

'Change Profile' in the settings menu went away, this is already available in the session context menu and not really settings.


Diffs (updated)
-----

  trunk/KDE/kdebase/apps/konsole/desktop/konsoleui.rc 1098894 
  trunk/KDE/kdebase/apps/konsole/desktop/partui.rc 1098894 
  trunk/KDE/kdebase/apps/konsole/desktop/sessionui.rc 1098894 
  trunk/KDE/kdebase/apps/konsole/src/MainWindow.h 1098894 
  trunk/KDE/kdebase/apps/konsole/src/MainWindow.cpp 1098894 
  trunk/KDE/kdebase/apps/konsole/src/Part.cpp 1098894 
  trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1098894 

Diff: http://reviewboard.kde.org/r/3110/diff


Testing
-------


Screenshots (updated)
-----------


  http://reviewboard.kde.org/r/3110/s/325/

  http://reviewboard.kde.org/r/3110/s/327/


Thanks,

Sascha