[Konsole-devel] Review Request: Mimic the Edit Profile->Tab Titles in the Rename Tab Dialog

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4528/
-----------------------------------------------------------

(Updated 2010-07-07 15:51:39.829574)


Review request for Konsole.


Changes
-------

Use QScopePointer and correct set methods.


Summary
-------

The current rename tab is very bland and non-user friendly.  This new dialog mimics the Edit Profile-> Tab Titles section.


This addresses bug 228129.
    https://bugs.kde.org/show_bug.cgi?id=228129


Diffs (updated)
-----

  trunk/KDE/kdebase/apps/konsole/src/CMakeLists.txt 1146398 
  trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.h PRE-CREATION 
  trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.cpp PRE-CREATION 
  trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.ui PRE-CREATION 
  trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1146398 

Diff: http://reviewboard.kde.org/r/4528/diff


Testing
-------

trunk


Thanks,

Kurt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20100707/020be085/attachment.html>