[Konsole-devel] Review Request: Mimic the Edit Profile->Tab Titles in the Rename Tab Dialog

[Robert Knight]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4528/#review6390
-----------------------------------------------------------


Mostly looks good to me.  A few minor comments.


trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.cpp
<http://reviewboard.kde.org/r/4528/#comment6126>

    The standard accessor naming is setProperty(), and property() so this would be named tabTitleText().
    
    (I suspect that might not be followed in some parts of code, but I think that was the standard in most new code.  Same as Qt in other words).



trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp
<http://reviewboard.kde.org/r/4528/#comment6125>

    I would recommend std::auto_ptr or QScopedPointer in favor of manual deletion.


- Robert


On 2010-07-06 15:05:44, Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4528/
> -----------------------------------------------------------
> 
> (Updated 2010-07-06 15:05:44)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> The current rename tab is very bland and non-user friendly.  This new dialog mimics the Edit Profile-> Tab Titles section.
> 
> 
> This addresses bug 228129.
>     https://bugs.kde.org/show_bug.cgi?id=228129
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/src/CMakeLists.txt 1146398 
>   trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.h PRE-CREATION 
>   trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.cpp PRE-CREATION 
>   trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.ui PRE-CREATION 
>   trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1146398 
> 
> Diff: http://reviewboard.kde.org/r/4528/diff
> 
> 
> Testing
> -------
> 
> trunk
> 
> 
> Thanks,
> 
> Kurt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20100706/a8fcf67e/attachment.html>