[Konsole-devel] Review Request: Adds support for SHELL_SESSION_ID

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3045/#review4268
-----------------------------------------------------------


Nice patch - it appears to work fine for session mgmt.  I did notice this: Open some tabs (say 3), close all of them and then open 3 more tabs.  The Ids from the first 3 will be the same for newly opened 3.  I'm not sure this is what you want.
Also, I'm not sure how nasty using the quuid is for people.  The {} and long # may be messy.

- Kurt


On 2010-02-24 08:19:27, argonel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3045/
> -----------------------------------------------------------
> 
> (Updated 2010-02-24 08:19:27)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Adds support for SHELL_SESSION_ID, re-purposing the apparently unused Session::_uniqueIdentifier as a QUuid.
> 
> Session data appears to be stored via KMainWindow::saveGlobalProperties instead of saveProperties, and I think this causes the Uuid field to be copied between like-numbered sessions when one instance has a Uuid and one does not.
> 
> Thoughts?
> 
> 
> This addresses bug 156563.
>     https://bugs.kde.org/show_bug.cgi?id=156563
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/Session.h 1079359 
>   /trunk/KDE/kdebase/apps/konsole/src/Session.cpp 1079359 
> 
> Diff: http://reviewboard.kde.org/r/3045/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> argonel
> 
>