[Konsole-devel] Review Request: Adds support for SHELL_SESSION_ID
argonel at gmail.com
argonel at gmail.com
Wed Feb 24 08:19:28 UTC 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3045/
-----------------------------------------------------------
Review request for Konsole.
Summary
-------
Adds support for SHELL_SESSION_ID, re-purposing the apparently unused Session::_uniqueIdentifier as a QUuid.
Session data appears to be stored via KMainWindow::saveGlobalProperties instead of saveProperties, and I think this causes the Uuid field to be copied between like-numbered sessions when one instance has a Uuid and one does not.
Thoughts?
This addresses bug 156563.
https://bugs.kde.org/show_bug.cgi?id=156563
Diffs
-----
/trunk/KDE/kdebase/apps/konsole/src/Session.h 1079359
/trunk/KDE/kdebase/apps/konsole/src/Session.cpp 1079359
Diff: http://reviewboard.kde.org/r/3045/diff
Testing
-------
Thanks,
argonel
More information about the konsole-devel
mailing list