[Konsole-devel] Review Request: Recreate hotspots on resize and check for invalid indicies

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2976/
-----------------------------------------------------------

(Updated 2010-02-23 16:01:17.143815)


Review request for Konsole.


Changes
-------

The new diff just has the processFilters when an actual resize is done.  I remove the checking of indicies for now.


Summary
-------

Konsole crashes now when the user resizes the window and there are hotspots (with spaces at end) that become invalid.  The fix is to get new hotspot locations upon resizing.  There is also a check for invalid indicies.
I would think this would affect performance as the hotspots will be regenerated upon every resize now. 


This addresses bug 199161.
    https://bugs.kde.org/show_bug.cgi?id=199161


Diffs (updated)
-----

  trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1094728 

Diff: http://reviewboard.kde.org/r/2976/diff


Testing
-------

Doesn't crash where it used to.  You need a hotspot (link) with spaces after it and then resize to finally trigger this bug.


Thanks,

Kurt