[Konsole-devel] Review Request: Recreate hotspots on resize and check for invalid indicies
Kurt Hindenburg
kurt.hindenburg at gmail.com
Tue Feb 16 14:47:37 UTC 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2976/
-----------------------------------------------------------
Review request for Konsole.
Summary
-------
Konsole crashes now when the user resizes the window and there are hotspots (with spaces at end) that become invalid. The fix is to get new hotspot locations upon resizing. There is also a check for invalid indicies.
I would think this would affect performance as the hotspots will be regenerated upon every resize now.
This addresses bug 199161.
https://bugs.kde.org/show_bug.cgi?id=199161
Diffs
-----
trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1090607
Diff: http://reviewboard.kde.org/r/2976/diff
Testing
-------
Doesn't crash where it used to. You need a hotspot (link) with spaces after it and then resize to finally trigger this bug.
Thanks,
Kurt
More information about the konsole-devel
mailing list