[Konsole-devel] [Bug 183069] Crash on removing key bindings

[Dario Andres]

https://bugs.kde.org/show_bug.cgi?id=183069





--- Comment #5 from Dario Andres <andresbajotierra gmail com>  2009-05-27 19:10:07 ---
(In reply to comment #4)
> Hi Dario,
> 
> Thanks for the patch - I think it would be simpler just to remove any items
> from the list returned by selectedItems() which are not in the first column
> before iterating over each item in the list to remove the rows.
> 

That could work if you set the selection mode to the whole row. Otherwise, user
could select a binding (2° column) and it won't be deleted (as the 1° column is
not selected)

> Alternatively, iterate through the selected items to create a set of selected
> rows then iterate through that set to remove the rows.

That is what my patch is doing: creating a new list of unique rows items and
then iterate normally.

Regards

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.