[Konsole-devel] Review Request: Fix for "Copy Input To" problems

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2375/#review3449
-----------------------------------------------------------


It appears to work and fix the given bug in my limited testing.  I didn't really review the code changes, although it look much cleaner now.

- Kurt


On 2009-12-14 09:10:50, Thomas Dreibholz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2375/
> -----------------------------------------------------------
> 
> (Updated 2009-12-14 09:10:50)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> The "Copy Input To" function does not work properly when there are two or more Konsole windows opened. This bug can be reproduced by opening two Konsole windows with multiple tabs. Activating "Copy Input To ... -> All Tabs in Current Window" may work in a tab of the second window, while it does not work in a tab of the first window.
> 
> The patch fixes this problem by rewritten SessionGroup methods. Also, the "Copy Input To" code is much simpler now.
> 
> 
> This addresses bug 218616.
>     https://bugs.kde.org/show_bug.cgi?id=218616
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/Session.h 1062211 
>   /trunk/KDE/kdebase/apps/konsole/src/Session.cpp 1062211 
>   /trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1062211 
> 
> Diff: http://reviewboard.kde.org/r/2375/diff
> 
> 
> Testing
> -------
> 
> Tested against revision 1062211.
> 
> 
> Thanks,
> 
> Thomas
> 
>