[Konsole-devel] Review Request: Fix for "Copy Input To" problems

Mon Dec 14 09:10:51 UTC 2009

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2375/
-----------------------------------------------------------

(Updated 2009-12-14 09:10:50.636242)

Review request for Konsole.

Changes
-------

Added bug number.

Summary
-------

The "Copy Input To" function does not work properly when there are two or more Konsole windows opened. This bug can be reproduced by opening two Konsole windows with multiple tabs. Activating "Copy Input To ... -> All Tabs in Current Window" may work in a tab of the second window, while it does not work in a tab of the first window.

The patch fixes this problem by rewritten SessionGroup methods. Also, the "Copy Input To" code is much simpler now.

This addresses bug 218616.
    https://bugs.kde.org/show_bug.cgi?id=218616

Diffs
-----

  /trunk/KDE/kdebase/apps/konsole/src/Session.h 1062211 
  /trunk/KDE/kdebase/apps/konsole/src/Session.cpp 1062211 
  /trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1062211 

Diff: http://reviewboard.kde.org/r/2375/diff

Testing
-------

Tested against revision 1062211.

Thanks,

Thomas