[Konsole-devel] Review Request: dbus interface - session portion

[Robert Knight]

> On 2009-04-16 20:21:35, Kurt Hindenburg wrote:
> > trunk/KDE/kdebase/apps/konsole/src/Session.h, line 486
> > <http://reviewboard.kde.org/r/577/diff/1/?file=5225#file5225line486>
> >
> >     I thought flow control couldn't be disabled?  It is greyed out the Edit Profile Dialog.

That's a bug because the KDE 4 kpty library didn't support flow control originally.  It ought to be re-enabled.


> On 2009-04-16 20:21:35, Kurt Hindenburg wrote:
> > trunk/KDE/kdebase/apps/konsole/src/Session.h, line 507
> > <http://reviewboard.kde.org/r/577/diff/1/?file=5225#file5225line507>
> >
> >     This and the foregroundProcessId are confusing.  A better name?

I can't think of a name which nicely captures the difference between the process id of the shell and the process id of the program controlling the terminal.  I think this might have to be clarified in the documentation.


> On 2009-04-16 20:21:35, Kurt Hindenburg wrote:
> > trunk/KDE/kdebase/apps/konsole/src/Session.h, line 520
> > <http://reviewboard.kde.org/r/577/diff/1/?file=5225#file5225line520>
> >
> >     After using this, the entry in Edit Profile Dialog is not updated.

That's correct - the text encoding can be changed per-session and per-profile.  Changing the codec for a particular session does not change the default for that profile.


> On 2009-04-16 20:21:35, Kurt Hindenburg wrote:
> > trunk/KDE/kdebase/apps/konsole/src/Session.h, line 532
> > <http://reviewboard.kde.org/r/577/diff/1/?file=5225#file5225line532>
> >
> >     Not sure how useful this is; I would prefer allowing to enter tab format (ie %d %n).

Looking at the documentation it appears that 'title' is actually a tab format and can contain '%' markers.  The 'role' argument is a value from the TitleRole enum.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/577/#review942
-----------------------------------------------------------


On 2009-04-12 13:48:36, Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/577/
> -----------------------------------------------------------
> 
> (Updated 2009-04-12 13:48:36)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> dbus interface - session portion
> 
> 
> This addresses bug 169024.
>     https://bugs.kde.org/show_bug.cgi?id=169024
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/src/Session.h 952914 
>   trunk/KDE/kdebase/apps/konsole/src/Session.cpp 952914 
>   trunk/KDE/kdebase/apps/konsole/src/org.kde.konsole.Session.xml 952914 
> 
> Diff: http://reviewboard.kde.org/r/577/diff
> 
> 
> Testing
> -------
> 
> briefly on trunk
> 
> 
> Thanks,
> 
> Kurt
> 
>