[Konsole-devel] Review Request: dbus interface - session portion

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/577/#review942
-----------------------------------------------------------



trunk/KDE/kdebase/apps/konsole/src/Session.h
<http://reviewboard.kde.org/r/577/#comment637>

    I thought flow control couldn't be disabled?  It is greyed out the Edit Profile Dialog.



trunk/KDE/kdebase/apps/konsole/src/Session.h
<http://reviewboard.kde.org/r/577/#comment638>

    This and the foregroundProcessId are confusing.  A better name?



trunk/KDE/kdebase/apps/konsole/src/Session.h
<http://reviewboard.kde.org/r/577/#comment639>

    After using this, the entry in Edit Profile Dialog is not updated.



trunk/KDE/kdebase/apps/konsole/src/Session.h
<http://reviewboard.kde.org/r/577/#comment640>

    Not sure how useful this is; I would prefer allowing to enter tab format (ie %d %n).


- Kurt


On 2009-04-12 13:48:36, Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/577/
> -----------------------------------------------------------
> 
> (Updated 2009-04-12 13:48:36)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> dbus interface - session portion
> 
> 
> This addresses bug 169024.
>     https://bugs.kde.org/show_bug.cgi?id=169024
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/src/Session.h 952914 
>   trunk/KDE/kdebase/apps/konsole/src/Session.cpp 952914 
>   trunk/KDE/kdebase/apps/konsole/src/org.kde.konsole.Session.xml 952914 
> 
> Diff: http://reviewboard.kde.org/r/577/diff
> 
> 
> Testing
> -------
> 
> briefly on trunk
> 
> 
> Thanks,
> 
> Kurt
> 
>