[Konsole-devel] Review Request: Allow %u (user) in tab name

Kurt Hindenburg kurt.hindenburg at gmail.com
Sat Apr 11 03:09:58 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/278/
-----------------------------------------------------------

(Updated 2009-04-10 20:09:58.146200)


Review request for Konsole.


Changes
-------

more updates to variable name and remove 'unknown' string


Summary
-------

Allow %u (user) in tab name.  It reads /proc/'pid'/status for UID and then calls getpwuid for user name.


This addresses bug 154295.
    https://bugs.kde.org/show_bug.cgi?id=154295


Diffs (updated)
-----

  trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.h 950710 
  trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp 950710 

Diff: http://reviewboard.kde.org/r/278/diff


Testing
-------

Patch works for 4.2 branch and trunk.  Works fine on Linux (ubuntu).  Works for 'su - user' and 'sudo command'


Thanks,

Kurt




More information about the konsole-devel mailing list