[Konsole-devel] Review Request: Allow %u (user) in tab name

[Robert Knight]

> On 2009-04-10 02:37:42, Robert Knight wrote:
> > trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp, line 355
> > <http://reviewboard.kde.org/r/278/diff/3/?file=5111#file5111line355>
> >
> >     "unknown" needs to be translated with i18n()
> 
>  wrote:
>     I was wondering if it should just be an empty string instead.  I'm not sure what user's would prefer: seeing nothing or 'unknown'

The main point of ProcessInfo was to automatically generate useful tab titles which make it easy to distinguish between tabs so actually an empty string would probably be better - if we can't display useful information then avoid showing it at all.  This will then leave room for the directory name or other info which is helpful.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/278/#review894
-----------------------------------------------------------


On 2009-04-07 21:55:22, Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/278/
> -----------------------------------------------------------
> 
> (Updated 2009-04-07 21:55:22)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Allow %u (user) in tab name.  It reads /proc/'pid'/status for UID and then calls getpwuid for user name.
> 
> 
> This addresses bug 154295.
>     https://bugs.kde.org/show_bug.cgi?id=154295
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.h 950710 
>   trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp 950710 
> 
> Diff: http://reviewboard.kde.org/r/278/diff
> 
> 
> Testing
> -------
> 
> Patch works for 4.2 branch and trunk.  Works fine on Linux (ubuntu).  Works for 'su - user' and 'sudo command'
> 
> 
> Thanks,
> 
> Kurt
> 
>