[Konsole-devel] [Bug 151966] Flow control active indicator appears anyway, when flow control keys are disabled for a profile

[Robert Knight]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=151966         




------- Additional Comments From robertknight gmail com  2008-04-07 03:44 -------
Hi Bob,

Comments on the patch in comment #6:

1.  The changes in your patch are not fixes for this bug report.  It helps maintenance if each bug report is kept to one bug or feature, plus links to any reports which this one depends on.  Non-trivial new features or bugs should go in a new report.    

2.  If you want to propose new features, with patches, then that is appreciated but I do need a rationale for why Konsole should have them and who would want to use them and how.  If you plan to make user interface changes then it is best to discuss those first before writing the code.  In this case for example you add two new checkboxes to the "Advanced" tab of the profile editor.  This tab is already quite tall - which means that it would need to be re-arranged first rather than just adding the new controls in-place.

3.  That is a large patch which has a mix of API documentation fixes, multiple new features and refactoring.  This is not easy to review and comment on because there is a lot going on.  Please break it down into separate patches - one per feature, bug fix, refactoring or documentation update.  Formatting changes, which I'd rather not see too many of, come under refactoring.