[Konsole-devel] [Bug 131770] no bold is displayed in konsole -- fix not ok

[lars.doelle at on-line.de]

Now bold is indeed broken, but I hate to say that the fix below is not in order.

> --- branches/KDE/3.5/kdebase/konsole/konsole/TEScreen.cpp #570193:570194
>  @ -501,7 +501,7  @
>  void TEScreen::effectiveRendition()
>  // calculate rendition
>  {
> -  ef_re = cu_re & (RE_UNDERLINE | RE_BLINK);
> +  ef_re = cu_re & (RE_UNDERLINE | RE_BLINK | RE_BOLD);
>    if (cu_re & RE_REVERSE)
>    {
>      ef_fg = cu_bg;

The omission of RE_BOLD in the line above was a feature.

The rendering might look like  xterm now, but this is bad. Xterm interprets
BOLD as intesive+bold. There are some oddities about intensive and bold
throughout various emulations, and the original version was a carefully
balanced treatment of this, now broken by the patch.

See [konsole/doc/color-schema] for some notes on it.

In general, the konsole interprets bold as intensive (like the linux console).
Only in particular situation, when e.g. intensive black == regular black, bold
is set. These exceptions are spelled in the *.schema files. This is subtile,
but wanted, as it improves the overall impression quite a bit.

I'll try to dig into the bug these days.

-lars