[Bug 202457] "Next Difference/File" crashes when viewing a "move" diff

Tue Nov 8 18:23:01 UTC 2011

https://bugs.kde.org/show_bug.cgi?id=202457


--- Comment #18 from Kevin Kofler <kevin kofler chello at>  2011-11-08 18:23:01 ---
So there are several things going wrong:
* In order to prevent the crash, in addition to the NULL check you added, I
guess KDirLVI::fillFileList should clear modelToFileItemDict. I guess adding
that is a good idea for robustness in any case. Otherwise, we end up with
nonsensical leaked hash table entries.
* However, that is not the root cause of the bug. The root cause is that we
aren't getting the correct directory preselected, which is why the file cannot
be found in the mapping (fixable by your NULL check), or a leaked old mapping
can be found in some cases (fixable by additionally clearing the dict as I'm
suggesting). The code which looks up the correct directory is apparently only
looking in the destination and not in the source, which means it fails when the
patch is a deletion. I'm still looking for the offending code.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.