New payees bug

[Jeremy Whiting]

Ok, I think I've hit the edge of my code following for the evening.
Everything in NewTransactionEditor looks right. It calls
KMyMoneyUtils::newPayee which works right and finds the index of the new
payee, etc. The only problem is that after it's done the
NewTransactionEditor gets destructed for some reason... It gets destructed
when you click Yes on the Create new payee question dialog. If you click No
instead it leaves the editor, but clears out the value for the payee as
expected. I'm not sure why the editor is getting destructed in the
LedgerView.

On Fri, Jul 21, 2023 at 5:31 PM Jeremy Whiting <jpwhiting at kde.org> wrote:

> Hello,
>
> I think there's a recent-ish bug in master. I'm not sure when I started
> hitting it since I don't often add new payees. But lately when adding a new
> transaction if you enter a new name for the payee it pops up the dialog "Do
> you want to add <foo> as a new payee?" which is how it always has been.
> However lately, clicking yes seems to add the payee to the payees, but also
> clears out the entered transaction data. It used to just add the payee and
> let you continue to edit the rest of the transaction details.
>
> Clicking No clears everything just like it used to.
>
> With a quick dive into the code I *think* it might be a bug around
> PayeeCreator::createPayee. I think when it calls KMyMoneyUtils::newPayee
> that works so it drops into the else block, but then somehow doesn't get an
> index from m_comboBox->findData (maybe because the combobox didn't get
> notified of the new payee?) so it clears everything out.
>
> I'll dive in and see if that's the cause and see if I can find out how to
> get it added to the combobox maybe, but wanted to point it out in case it's
> already known and maybe in progress somewhere.
>
> thanks,
> Jeremy
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20230721/0ed5cf6d/attachment-0001.htm>