[kmymoney] [Bug 395025] csv writer generates invalid file in case field delimiter is used in any field

Thomas Baumgart bugzilla_noreply at kde.org
Tue Jun 5 15:40:06 UTC 2018


https://bugs.kde.org/show_bug.cgi?id=395025

Thomas Baumgart <thb at net-bembel.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/kmy |https://commits.kde.org/kmy
                   |money/12fa3bbffb164737c8fd0 |money/638b0eacfdcc79cf67db7
                   |b564c5596c4933a5d35         |47889f50381259fd703

--- Comment #4 from Thomas Baumgart <thb at net-bembel.de> ---
Git commit 638b0eacfdcc79cf67db747889f50381259fd703 by Thomas Baumgart.
Committed on 05/06/2018 at 15:33.
Pushed by tbaumgart into branch 'master'.

Allow field delimiter as character in CSV exports

This commit fixes all fields which may have field separators like
payee, acccount, category, memo, number and money related fields.

Additional fixes:
- the commit also handles double quotes inside string fields according
  to RFC 4180

Note: The previous implementation removed single quotes from memo
fields, which is now applied to all string fields because all string
fields are formatted by the same method. If this could be removed,
please file a related request.

Test Plan: compiled and exported to csv on linux

Reviewers: #kmymoney, tbaumgart

Reviewed By: tbaumgart

Subscribers: tbaumgart

Differential Revision: https://phabricator.kde.org/D13330

Signed-off-by: Ralf Habacker <ralf.habacker at freenet.de>

Cherry-picked from 12fa3bbffb164737c8fd0b564c5596c4933a5d35 and adjusted
for master

M  +52   -38   kmymoney/plugins/csv/export/csvwriter.cpp
M  +3    -0    kmymoney/plugins/csv/export/csvwriter.h

https://commits.kde.org/kmymoney/638b0eacfdcc79cf67db747889f50381259fd703

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the KMyMoney-devel mailing list