[kmymoney] [Bug 395025] csv writer generates invalid file in case field delimiter is used in any field

Ralf Habacker bugzilla_noreply at kde.org
Tue Jun 5 10:21:16 UTC 2018


https://bugs.kde.org/show_bug.cgi?id=395025

Ralf Habacker <ralf.habacker at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kmy
                   |                            |money/12fa3bbffb164737c8fd0
                   |                            |b564c5596c4933a5d35
   Version Fixed In|                            |4.8.3
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Ralf Habacker <ralf.habacker at freenet.de> ---
Git commit 12fa3bbffb164737c8fd0b564c5596c4933a5d35 by Ralf Habacker.
Committed on 05/06/2018 at 10:21.
Pushed by habacker into branch '4.8'.

Fix 'csv writer generates invalid file in case field delimiter is used in any
field'

This commit fixes all fields which may have field separators like
payee, acccount, category, memo, number and money related fields.

Additional fixes:
- the commit also handle double quotes inside string fields according
  RFC 4180

Note: The previous implementation removed single quotes from memo fields,
which is now applied to all string fields because all string fields are
formatted by the same method. If this could be removed, please file a
related request.
FIXED-IN:4.8.3

Test Plan: compiled and exported to csv on linux

Reviewers: #kmymoney, tbaumgart

Reviewed By: tbaumgart

Subscribers: tbaumgart

Differential Revision: https://phabricator.kde.org/D13330

Signed-off-by: Ralf Habacker <ralf.habacker at freenet.de>

M  +52   -43   kmymoney/plugins/csvexport/csvwriter.cpp
M  +2    -0    kmymoney/plugins/csvexport/csvwriter.h

https://commits.kde.org/kmymoney/12fa3bbffb164737c8fd0b564c5596c4933a5d35

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the KMyMoney-devel mailing list