compile failure with git master

[Thomas Baumgart]

Jack,

On Sonntag, 31. Dezember 2017 13:00:27 CET Jack wrote:

> Thomas,
> 
> On 2017.12.31 11:42, Thomas Baumgart wrote:
> > On Sonntag, 31. Dezember 2017 11:33:42 CET Jack Ostroff wrote:
> > > With a fresh pull from git master, I get a compile failure
> > > 
> > > [ 20%] Building CXX object
> > 
> > kmymoney/dialogs/CMakeFiles/dialogs.dir/kreportconfigurationfilterdlg.cpp.
> > o
> > 
> > /path-to-source/kmymoney/dialogs/kreportconfigurationfilterdlg.cpp:61:33:
> > > fatal error: ui_reporttabgeneral.h: No such file or directory
> > > 
> > >   #include <ui_reporttabgeneral.h>
> > > 
> > > Looking at an old build folder I still have, that file appears in
> > > /path-to build/kmymoney/widgets/.  If I cd to that directory, type
> > > "make" there, and then resume make in the top build directory, it
> > > completes with no errors.
> > > 
> > > I suspect that some recent change to the CMake files changed the
> > 
> > order
> > 
> > > of things.
> 
> Well, I also discovered two new build (actually cmake) issues.  First,
> it appears that building OFX is no longer the default.  I had to
> explicitly add -DENABLE_OFXIMPORTER=TRUE to my cmake line, because
> without it, it did NOT enable ofx.  (We also need to update README.ofx
> - I'll try to do that later today.) 

Nope, please see https://phabricator.kde.org/D9584 which should bring back the 
original behavior. Please feel free to test it as well.

> Anyway, I also had some moc
> related warnings on "make install" but we'll see if they also go away
> if I fix this problem.  In addition, "Generate API documentation with
> Doxygen" is now "yes" and I don't think it used to be, and I know I do
> not address it directly in my cmake command.

moc should not run during make install if you have done a make beforehand.

> > Strange.
> > https://build.kde.org/job/Extragear%20kmymoney%20kf5-qt5%20SUSEQt5.9/
> > shows no problems with a build from scratch. And the part you mention
> > is not
> > optional.
> > 
> > Try the following:
> >   cd <<your build directory>>
> >   mv CMakeCache.txt CMakeCache.txt.old
> >   cmake <<any options you need>>  <<your src directory>>
> >   make
> 
> OK, I started with an empty build dir, did cmake (with the explicit
> enabling of ofx,) and got the same error.  I then renamed
> CMakeCache.txt and reran cmake.  Same error.
> My cmake command is
> 
> cmake -DCMAKE_BUILD_TYPE=Debug
> -DCMAKE_INSTALL_PREFIX=/home/jack/KDE/KMM/installframeworks
> -DLibAlkimia5_DIR=/home/jack/KDE/KMM/installframeworks/lib64/cmake/LibAlkimi
> a-6.0 -DENABLE_OFXIMPORTER=TRUE ../kmymoney-git
> 
> and my build directory is parallel to the source directory.  However, I
> also tried with the build directory under the source directory, and had
> the same result.
> 
> > in case cmake worked
> 
> cmake doesn't produce any errors, but make still fails.
> 
> >   rm CMakeCache.txt.old
> > 
> > Regards
> > Thomas Baumgart
> 
> just in case it matters, I have cmake 3.9.6, and Gnu make 4.2.1.  I'm
> currently using gcc 6.4.0.

I am certainly using different versions. That might have something to do with 
it. I will take the patch provided by Alexandre and create a phabricator diff 
and have you check it before I commit anything.

-- 

Regards

Thomas Baumgart

https://www.telegram.org/       Telegram, the better WhatsApp
-------------------------------------------------------------
'Knowing a computer language is neither a necessary nor a sufficient
condition to know how to construct a computer program' -- J.R. Tyrer
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 846 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20180101/f8826a9b/attachment.sig>