Review Request 129852: Display the sum of sub-categories when category is expanded

[Albert Astals Cid]

> On Jan. 20, 2017, 6:31 p.m., Thomas Baumgart wrote:
> > Ship It!
> 
> Marc Hübner wrote:
>     Dear Thomas,
>     Sorry if this is a dumb question - but what exactly am I supposed to do when I got the "Ship It" info?
>     Commit the patch to master (in that case I suppose I need a dev account/write access to the repo first) - or have someone else merge it? Or is reviewboard integrated with the repo and the merge is done automatically once I click "ship it" here?
>     
>     I read https://community.kde.org/Get_Involved/development but didn't really find anything specific to kmymoney. Is there any more specific documentation available on this?
>     
>     Thanks,
>     Marc

Usually a developer of the project would commit it if you ask them, and after a few patches you should get commit access. Today i am doing some janitoring so I've commited it myself.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129852/#review102115
-----------------------------------------------------------


On Jan. 21, 2017, 12:07 a.m., Marc Hübner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129852/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2017, 12:07 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 373550
>     http://bugs.kde.org/show_bug.cgi?id=373550
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Please see bug #373550. Adds a new column to the categories view. The (previously existing) "total" column does now always hold the summed value (no matter whether a subtotal position is expanded or collapsed). The new "posted amount" column only holds the value that was assigned to the category directly (that is, without subcategories).
> 
> 
> Diffs
> -----
> 
>   kmymoney/models/accountsmodel.h d819428 
>   kmymoney/models/accountsmodel.cpp b395e16 
> 
> Diff: https://git.reviewboard.kde.org/r/129852/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marc Hübner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170121/6e294fa2/attachment.html>