Review Request 129740: Block model signals during drawPivotRowSet

[Łukasz Wojniłowicz]

> On Sty 6, 2017, 6:17 po południu, Thomas Baumgart wrote:
> > kmymoney/reports/kreportchartview.cpp, line 261
> > <https://git.reviewboard.kde.org/r/129740/diff/1/?file=488353#file488353line261>
> >
> >     You should use
> >     
> >     const bool blocked = m_model.blockSignals(true);
> >       :
> >       :
> >     m_model.blockSignals(blocked);
> >       
> >     here to be prepared if somebody else already disabled the signals before you get here. It's just good practice to do so.

Is it OK now?


- Łukasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129740/#review101841
-----------------------------------------------------------


On Sty 8, 2017, 5:10 po południu, Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129740/
> -----------------------------------------------------------
> 
> (Updated Sty 8, 2017, 5:10 po południu)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 374430
>     http://bugs.kde.org/show_bug.cgi?id=374430
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Fixes bug #374430
> 
> 
> Diffs
> -----
> 
>   kmymoney/reports/kreportchartview.cpp 2a04c45 
> 
> Diff: https://git.reviewboard.kde.org/r/129740/diff/
> 
> 
> Testing
> -------
> 
> .kmy file from bug #374430
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170108/0cf6c154/attachment.html>