Review Request 129740: Block model signals during drawPivotRowSet

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129740/#review101841
-----------------------------------------------------------



Once you have taken care of my comment, you have my 'ship it'.


kmymoney/reports/kreportchartview.cpp (line 261)
<https://git.reviewboard.kde.org/r/129740/#comment68140>

    You should use
    
    const bool blocked = m_model.blockSignals(true);
      :
      :
    m_model.blockSignals(blocked);
      
    here to be prepared if somebody else already disabled the signals before you get here. It's just good practice to do so.


- Thomas Baumgart


On Jan. 1, 2017, 7:27 nachm., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129740/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2017, 7:27 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 374430
>     http://bugs.kde.org/show_bug.cgi?id=374430
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Fixes bug #374430
> 
> 
> Diffs
> -----
> 
>   kmymoney/reports/kreportchartview.cpp 2a04c45 
> 
> Diff: https://git.reviewboard.kde.org/r/129740/diff/
> 
> 
> Testing
> -------
> 
> .kmy file from bug #374430
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20170106/8d94e7b5/attachment.html>