Review Request 130210: initial doc update for 4.8.1

[Jack]

[still to the list and not posted to the review]

On 2017.08.31 14:13, Ralf Habacker wrote:
> Am 31.08.2017 um 20:01 schrieb Jack:
> >
>> I've published the final review, and I thought the next step would  
>> be to land it, but
> >
> > "rbt land --dry-run" or "rbt land --dry-run 4.8" tells me
> >      "ERROR: Please specify a destination branch." and
> >
> > "rbt land --dry-run --dest 4.8" or "rbt land --dry-run --dest 4.8"  
> say
> >      "ERROR: The local branch cannot be merged onto itself. Try a
> > different local branch or destination branch."
> >
>> Is this because I made my changes in the 4.8 branch instead of a  
>> branch created specifically for this review? 
> I cannot say, because I do not use this.rbt command. Normally I edit  
> the related commit, add a REVIEW:xxx tag and run git push.
> 
> 
> > Am I correct that now I need to do a "git push"
> yes
> > and then "rbt close" separately?
> no, if you have a REVIEW: tag in the commit message (see
> https://cgit.kde.org/kmymoney.git/commit/?h=4.8&id=7516308bfbd2d5efb2e698f8f8b4930bccc81c47
> for an example)
> git push does this for you.

Thanks Ralf.  I've done a final update to the review just for the  
record, and then pushed.  The review is closed (if there are further  
comments, I can either open a Phabricator review or just discuss here  
and push directly.)  However, I got several errors as part of the push  
"remote: ERROR - Communication problem with Reviewboard. Please contact  
the KDE sysadmins."  I've opened a ticket with the sysadmins, but don't  
know if it's a real problem, as I don't see any issues from my side.

Jack