Review Request 128924: Simplify InvestmentPage::validatePage()

Łukasz Wojniłowicz lukasz.wojnilowicz at
Fri Sep 23 15:05:58 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 23, 2016, 11:05 a.m.)


This change has been marked as submitted.

Review request for KMymoney.


Submitted with commit 7a1121cd7702e896988e3b370988519280627f6f by ?ukasz Wojni?owicz to branch master.

Repository: kmymoney


1) renamed symboltabledlg to securitiesdlg,
2) simplified securitiesdlg,
3) securitiesdlg is initialized only once and invalidated by change of
name or symbol column,
4) display only unrecognized securities and not all,
5) don't change letter case of symbol and name in statement to be
6) symbol can be matched to multiple security names and not just to
first match,
7) fill m_listSecurities only once with newly introduced m_mapSymbolName
8) tidied up investprocessing includes,
9) initialize m_investProcessing and m_csvDialog only when needed and
not always at the start.


  kmymoney/plugins/csvimport/CMakeLists.txt 1103db7 
  kmymoney/plugins/csvimport/csvdialog.h ecf64d6 
  kmymoney/plugins/csvimport/csvdialog.cpp 7001b14 
  kmymoney/plugins/csvimport/csvwizard.h de58cf3 
  kmymoney/plugins/csvimport/csvwizard.cpp db8b439 
  kmymoney/plugins/csvimport/investprocessing.h 3d35409 
  kmymoney/plugins/csvimport/investprocessing.cpp 88d59d3 
  kmymoney/plugins/csvimport/securitiesdlg.h PRE-CREATION 
  kmymoney/plugins/csvimport/securitiesdlg.cpp PRE-CREATION 
  kmymoney/plugins/csvimport/securitiesdlg.ui PRE-CREATION 
  kmymoney/plugins/csvimport/symboltabledlg.h 786f048 
  kmymoney/plugins/csvimport/symboltabledlg.cpp 7beb68e 
  kmymoney/plugins/csvimport/symboltabledlg.ui 837a35a 




Łukasz Wojniłowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KMyMoney-devel mailing list