<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128924/">https://git.reviewboard.kde.org/r/128924/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2016, 11:05 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 7a1121cd7702e896988e3b370988519280627f6f by ?ukasz Wojni?owicz to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) renamed symboltabledlg to securitiesdlg,
2) simplified securitiesdlg,
3) securitiesdlg is initialized only once and invalidated by change of
name or symbol column,
4) display only unrecognized securities and not all,
5) don't change letter case of symbol and name in statement to be
imported,
6) symbol can be matched to multiple security names and not just to
first match,
7) fill m_listSecurities only once with newly introduced m_mapSymbolName
data,
8) tidied up investprocessing includes,
9) initialize m_investProcessing and m_csvDialog only when needed and
not always at the start.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/CMakeLists.txt <span style="color: grey">(1103db7)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: grey">(ecf64d6)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: grey">(7001b14)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.h <span style="color: grey">(de58cf3)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.cpp <span style="color: grey">(db8b439)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.h <span style="color: grey">(3d35409)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(88d59d3)</span></li>
<li>kmymoney/plugins/csvimport/securitiesdlg.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/securitiesdlg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/securitiesdlg.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/symboltabledlg.h <span style="color: grey">(786f048)</span></li>
<li>kmymoney/plugins/csvimport/symboltabledlg.cpp <span style="color: grey">(7beb68e)</span></li>
<li>kmymoney/plugins/csvimport/symboltabledlg.ui <span style="color: grey">(837a35a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128924/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>