Review Request 128878: Add slotSaveAsQIFClicked to CSV Importer

[Łukasz Wojniłowicz]

> On Wrz 11, 2016, 12:09 po południu, Allan Anderson wrote:
> > It was actually on my todo list to remove the QIF facility as it no longer had any purpose.  It was a relict from early days before CSV import became fully established.
> > I had indicated this on the lists several times without receiving any protests.  It's possible, I suppose, that on implementation, a non-lister might discover that a much needed feature had been removed.  I would still have gone ahead, but the change would have had to be reverted in that circumstance.
> > Perhaps you see a need?

I didn't know that you wanted to remove QIF facility. I don't use it personally. Initially I wanted to move it as separate CSV->QIF converter but it would involve the same steps you do during CSV import, so I left it where it is.
I think defeaturing CSV importer of QIF converter would be loss of work.


- Łukasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128878/#review99081
-----------------------------------------------------------


On Wrz 10, 2016, 6:35 po południu, Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128878/
> -----------------------------------------------------------
> 
> (Updated Wrz 10, 2016, 6:35 po południu)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> 1) It's now possible to save qif file with investments,
> 2) If account is available, then it will be added to qif file,
> 3) If type of import is available, then it will be added to qif file,
> 4) Handled canceling of QFileDialog,
> 5) QFileDialog saves only .qif files now,
> 6) Date format is hardcoded to MM/dd/yyyy, because it is so in files, that I saw.
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/csvimport/csvdialog.h 3cedd92 
>   kmymoney/plugins/csvimport/csvdialog.cpp 556d1c5 
>   kmymoney/plugins/csvimport/csvwizard.h 48c15ea 
>   kmymoney/plugins/csvimport/csvwizard.cpp fcf73fd 
>   kmymoney/plugins/csvimport/investprocessing.h 6ca2e53 
>   kmymoney/plugins/csvimport/investprocessing.cpp 7499b10 
> 
> Diff: https://git.reviewboard.kde.org/r/128878/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160911/56ec5d04/attachment.html>