<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128878/">https://git.reviewboard.kde.org/r/128878/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Wrzesień 11th, 2016, 12:09 po południu CEST, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It was actually on my todo list to remove the QIF facility as it no longer had any purpose. It was a relict from early days before CSV import became fully established.
I had indicated this on the lists several times without receiving any protests. It's possible, I suppose, that on implementation, a non-lister might discover that a much needed feature had been removed. I would still have gone ahead, but the change would have had to be reverted in that circumstance.
Perhaps you see a need?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I didn't know that you wanted to remove QIF facility. I don't use it personally. Initially I wanted to move it as separate CSV->QIF converter but it would involve the same steps you do during CSV import, so I left it where it is.
I think defeaturing CSV importer of QIF converter would be loss of work.</p></pre>
<br />
<p>- Łukasz</p>
<br />
<p>On Wrzesień 10th, 2016, 6:35 po południu CEST, Łukasz Wojniłowicz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<p style="color: grey;"><i>Updated Wrz 10, 2016, 6:35 po południu</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) It's now possible to save qif file with investments,
2) If account is available, then it will be added to qif file,
3) If type of import is available, then it will be added to qif file,
4) Handled canceling of QFileDialog,
5) QFileDialog saves only .qif files now,
6) Date format is hardcoded to MM/dd/yyyy, because it is so in files, that I saw.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: grey">(3cedd92)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: grey">(556d1c5)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.h <span style="color: grey">(48c15ea)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.cpp <span style="color: grey">(fcf73fd)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.h <span style="color: grey">(6ca2e53)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(7499b10)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128878/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>