Review Request 128817: Restructure pages in CSV Importer

Łukasz Wojniłowicz lukasz.wojnilowicz at
Sun Sep 4 18:29:40 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 4, 2016, 8:29 p.m.)

Review request for KMymoney.

Summary (updated)

Restructure pages in CSV Importer

Repository: kmymoney

Description (updated)

I actually decided to get rid of completion page and restructure LinesDate page. In my opinion it's more logical now and better structured for new feature I introduced ie. calculate fee column on fly.

1) shortened updateDecimalSymbol and renamed it to
2) introduced detectDecimalSymbol for autodetecting decimal symbol,
3) simplified createStatement,
4) simplified and deduplicated slotImportClicked,
5) new decimal symbol option 'auto' for columns with various decimal
6) decimal symbol and date format get checked every time formats page is
being opened,
7) removed completion page,
8) introduced rows page after separator page which is usefull for
calculate fee
9) introduced formats page which groups all validity checks in one
10) checking securities existence is now part of
11) validateDateFormat operates on tableWidget and not on m_lines so it
can be faster,
12) renamed page labels so they represent the content better,
13) Rows and Formats page have layout equal to Separator page, so look is more consistent.

Diffs (updated)

  kmymoney/plugins/csvimport/CMakeLists.txt 216c79c 
  kmymoney/plugins/csvimport/completionwizardpage.ui 616e0c3 
  kmymoney/plugins/csvimport/csvdialog.h 59e6898 
  kmymoney/plugins/csvimport/csvdialog.cpp ed9e1d8 
  kmymoney/plugins/csvimport/csvwizard.h ecec5b0 
  kmymoney/plugins/csvimport/csvwizard.cpp b576dea 
  kmymoney/plugins/csvimport/csvwizard.ui 723e128 
  kmymoney/plugins/csvimport/investprocessing.h 902f9bb 
  kmymoney/plugins/csvimport/investprocessing.cpp f050441 
  kmymoney/plugins/csvimport/separatorwizardpage.ui 2ad5abd 




Łukasz Wojniłowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KMyMoney-devel mailing list